From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YROu9-0008Ih-SV
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 12:40:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YROu7-0003fO-2e
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 12:40:49 -0500
Received: from cantor2.suse.de ([195.135.220.15]:38710 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1YROu6-0003f5-Ih
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 12:40:46 -0500
Message-ID: <54F0AC1D.6070807@suse.de>
Date: Fri, 27 Feb 2015 18:40:45 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <54E9DA4D.1050702@sunrus.com.cn> <54E9DB40.6000301@sunrus.com.cn>
In-Reply-To: <54E9DB40.6000301@sunrus.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/6 v4] linux-user: Support tilegx
 architecture in syscall
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, qemu-devel <qemu-devel@nongnu.org>, Chris Metcalf <cmetcalf@ezchip.com>, "walt@tilera.com" <walt@tilera.com>, "rth@twiddle.net" <rth@twiddle.net>

Am 22.02.2015 um 14:36 schrieb Chen Gang S:
> Add tilegx architecture in "syscall_defs.h", all related features (ioct=
rl,
> and stat) are based on Linux kernel tilegx 64-bit implementation.
>=20
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  linux-user/syscall_defs.h | 38 ++++++++++++++++++++++++++++++++++----
>  1 file changed, 34 insertions(+), 4 deletions(-)
>=20
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 9ed6de8..a0d9d77 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
[...]
> @@ -2312,7 +2340,9 @@ struct target_flock {
>  struct target_flock64 {
>  	short  l_type;
>  	short  l_whence;
> -#if defined(TARGET_PPC) || defined(TARGET_X86_64) || defined(TARGET_MI=
PS) || defined(TARGET_SPARC) || defined(TARGET_HPPA) || defined (TARGET_M=
ICROBLAZE)
> +#if defined(TARGET_PPC) || defined(TARGET_X86_64) || defined(TARGET_MI=
PS) || \
> +    defined(TARGET_SPARC) || defined(TARGET_HPPA) \
> +    || defined(TARGET_MICROBLAZE) || defined(TARGET_TILEGX)

Nit: You're inconsistent as to where you're placing ||.

Regards,
Andreas

>          int __pad;
>  #endif
>  	unsigned long long l_start;
>=20


--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N=C3=BCrnberg)