From: "Andreas Färber" <afaerber@suse.de>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel <qemu-devel@nongnu.org>,
Chris Metcalf <cmetcalf@ezchip.com>,
"walt@tilera.com" <walt@tilera.com>,
"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros which are not defined in tilegx
Date: Fri, 27 Feb 2015 19:24:31 +0100 [thread overview]
Message-ID: <54F0B65F.2050607@suse.de> (raw)
In-Reply-To: <54E9DB99.2000303@sunrus.com.cn>
Am 22.02.2015 um 14:37 schrieb Chen Gang S:
> For tilegx, several syscall macros are not supported, so switch them to
> avoid building break.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> linux-user/syscall.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 49 insertions(+), 1 deletion(-)
LGTM,
Reviewed-by: Andreas Färber <afaerber@suse.de>
However I suggest "conditionalize syscalls" or "disable syscalls" over
"switch ... macros/them".
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-02-27 18:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 13:31 [Qemu-devel] [PATCH 0/6 v4] tilegx: Can load elf64 tilegx binary successfully for linux-user Chen Gang S
2015-02-22 13:33 ` [Qemu-devel] [PATCH 1/6 v4] target-tilegx: Firstly add to qemu with minimized features Chen Gang S
2015-02-27 17:36 ` Andreas Färber
2015-02-27 21:49 ` Chris Metcalf
2015-02-28 2:10 ` Chen Gang S
2015-02-28 2:09 ` Chris Metcalf
2015-02-28 4:39 ` Chen Gang S
2015-02-28 5:20 ` Chen Gang S
2015-02-28 20:04 ` Chen Gang S
2015-02-28 19:19 ` Chen Gang S
2015-02-22 13:35 ` [Qemu-devel] [PATCH 3/6 v4] linux-user: tilegx: Add target features support within qemu Chen Gang S
2015-02-22 13:36 ` [Qemu-devel] [PATCH 4/6 v4] linux-user: Support tilegx architecture in syscall Chen Gang S
2015-02-27 17:40 ` Andreas Färber
2015-02-27 23:10 ` Chen Gang S
2015-02-22 13:36 ` [Qemu-devel] [PATCH 5/6 v4] linux-user: Support tilegx architecture in linux-user Chen Gang S
2015-02-22 13:37 ` [Qemu-devel] [PATCH 6/6 v4] linux-user/syscall.c: Switch all macros which are not defined in tilegx Chen Gang S
2015-02-27 18:24 ` Andreas Färber [this message]
2015-02-27 23:06 ` Chen Gang S
2015-02-22 18:29 ` [Qemu-devel] [PATCH 0/6 v4] tilegx: Can load elf64 tilegx binary successfully for linux-user Richard Henderson
2015-02-23 1:40 ` Chen Gang S
2015-02-22 22:32 ` Bastian Koppelmann
2015-02-23 1:37 ` Chen Gang S
2015-02-26 23:56 ` Chen Gang S
2015-02-27 0:32 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F0B65F.2050607@suse.de \
--to=afaerber@suse.de \
--cc=cmetcalf@ezchip.com \
--cc=gang.chen@sunrus.com.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).