From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPuB-00040J-Du for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:44:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRPu8-0002NH-04 for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:44:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRPu7-0002N8-Hx for qemu-devel@nongnu.org; Fri, 27 Feb 2015 13:44:51 -0500 Message-ID: <54F0BB20.4060100@redhat.com> Date: Fri, 27 Feb 2015 11:44:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424473645-29161-1-git-send-email-jsnow@redhat.com> <1424473645-29161-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1424473645-29161-4-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PeE6Jec7XFdanC9DfQQ3g39oiQnBIE6po" Subject: Re: [Qemu-devel] [PATCH v14 03/19] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PeE6Jec7XFdanC9DfQQ3g39oiQnBIE6po Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/20/2015 04:07 PM, John Snow wrote: > The new command pair is added to manage a user created dirty bitmap. Th= e > dirty bitmap's name is mandatory and must be unique for the same device= , > but different devices can have bitmaps with the same names. >=20 > The granularity is an optional field. If it is not specified, we will > choose a default granularity based on the cluster size if available, > clamped to between 4K and 64K to mirror how the 'mirror' code was > already choosing granularity. If we do not have cluster size info > available, we choose 64K. This code has been factored out into a helper= > shared with block/mirror. >=20 > This patch also introduces the 'block_dirty_bitmap_lookup' helper, > which takes a device name and a dirty bitmap name and validates the > lookup, returning NULL and setting errp if there is a problem with > either field. This helper will be re-used in future patches in this > series. >=20 > The types added to block-core.json will be re-used in future patches > in this series, see: > 'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disa= ble}' >=20 > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block.c | 20 ++++++++++ > block/mirror.c | 10 +---- > blockdev.c | 100 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 1 + > qapi/block-core.json | 55 +++++++++++++++++++++++++++ > qmp-commands.hx | 51 +++++++++++++++++++++++++ > 6 files changed, 228 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PeE6Jec7XFdanC9DfQQ3g39oiQnBIE6po Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU8LsgAAoJEKeha0olJ0NqJd0H/3jhwk3Nq/6QY4OmK3VThT+T eHPC0jZ7q6tIUhZOqagVnSAO2le/mcZQ/u64bw2LkIV6d561ZCfpU5Uritg6+xiZ GC6U4lHBF+7asQMqlnmVv+98SBeHN+Cyep5MqrlJRLpyr2UP/msF3LU7akyDWsvp 2uYjFtXWMMyDSzTJnUNvPPhAVwrJGOCLAG6B3kXZOVXxNtI3XSJJx0mMzCZBmrcv IrIRSa46aUPDVIEwHc8oCVE5S+lTA5/iWwQuL8AWJWvph/uCqd6+G3uQ3Q7oOZle 7beTzGMlQ0BVvkIasxtzwJ4gpHvtn23ZRrEm6W23thy3S+XSF9yJ3pQ+QweOiRc= =5+Xw -----END PGP SIGNATURE----- --PeE6Jec7XFdanC9DfQQ3g39oiQnBIE6po--