Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] PPC: Introduce the Virtual Time Base (VTB) SPR register

[Alexander Graf <agraf@suse.de>]

On 27.02.15 16:28, Alexander Graf wrote:
> 
> 
> On 27.02.15 00:19, Cyril Bur wrote:
>> This patch adds basic support for the VTB.
>>
>> PowerISA:
>> The Virtual Time Base (VTB) is a 64-bit incrementing counter.
>> Virtual Time Base increments at the same rate as the Time Base until its value
>> becomes 0xFFFF_FFFF_FFFF_FFFF (2 64 - 1); at the next increment its value
>> becomes 0x0000_0000_0000_0000. There is no interrupt or other indication when
>> this occurs.
>>
>> The operation of the Virtual Time Base has the following additional
>> properties.
>> 1. Loading a GPR from the Virtual Time Base has no effect on the accuracy of
>> the Virtual Time Base.
>> 2. Copying the contents of a GPR to the Virtual Time Base replaces the
>> contents of the Virtual Time Base with the contents of the GPR.
>>
>> Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
> 
> Thanks, applied to ppc-next.

Sorry, the patch breaks compilation for ppc-softmmu:

  target-ppc/translate_init.c:877:13: error: ‘gen_spr_vtb’ defined but
not used [-Werror=unused-function]

Please move the definition of gen_spr_vtb to the other p8 related spr
registration functions so it only gets added when we compile for 64bit.

I've removed the patch from my queue again.


Alex