From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YRSJ2-0002Dt-7E
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 16:18:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YRSIx-00079W-GZ
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 16:18:44 -0500
Message-ID: <54F0DF2C.8080706@suse.de>
Date: Fri, 27 Feb 2015 22:18:36 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1424992797-10016-1-git-send-email-cyril.bur@au1.ibm.com>
	<54F08D09.6050508@suse.de>
In-Reply-To: <54F08D09.6050508@suse.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] PPC: Introduce the Virtual
 Time Base (VTB) SPR register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cyril Bur <cyril.bur@au1.ibm.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org



On 27.02.15 16:28, Alexander Graf wrote:
>=20
>=20
> On 27.02.15 00:19, Cyril Bur wrote:
>> This patch adds basic support for the VTB.
>>
>> PowerISA:
>> The Virtual Time Base (VTB) is a 64-bit incrementing counter.
>> Virtual Time Base increments at the same rate as the Time Base until i=
ts value
>> becomes 0xFFFF_FFFF_FFFF_FFFF (2 64 - 1); at the next increment its va=
lue
>> becomes 0x0000_0000_0000_0000. There is no interrupt or other indicati=
on when
>> this occurs.
>>
>> The operation of the Virtual Time Base has the following additional
>> properties.
>> 1. Loading a GPR from the Virtual Time Base has no effect on the accur=
acy of
>> the Virtual Time Base.
>> 2. Copying the contents of a GPR to the Virtual Time Base replaces the
>> contents of the Virtual Time Base with the contents of the GPR.
>>
>> Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com>
>=20
> Thanks, applied to ppc-next.

Sorry, the patch breaks compilation for ppc-softmmu:

  target-ppc/translate_init.c:877:13: error: =91gen_spr_vtb=92 defined bu=
t
not used [-Werror=3Dunused-function]

Please move the definition of gen_spr_vtb to the other p8 related spr
registration functions so it only gets added when we compile for 64bit.

I've removed the patch from my queue again.


Alex