From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
peter.huangpeng@huawei.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/9] e500: fix memory leak
Date: Sat, 28 Feb 2015 17:57:36 +0800 [thread overview]
Message-ID: <54F19110.7080902@huawei.com> (raw)
In-Reply-To: <54F18D2E.1060501@msgid.tls.msk.ru>
On 2015/2/28 17:41, Michael Tokarev wrote:
> 27.02.2015 10:50, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>> hw/ppc/e500.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
>> index 7e17d18..38203a6 100644
>> --- a/hw/ppc/e500.c
>> +++ b/hw/ppc/e500.c
>> @@ -542,6 +542,7 @@ done:
>>
>> out:
>> g_free(pci_map);
>> + g_free(filename);
>
> This patch breaks compilation, because `filename' variable is
> local to the "if (dtb_file)" code block at the beginning of this
> function and shold be freed there.
>
Yes, it is. Thanks for your review, I'll respin it.
Regards,
-Gonglei
next prev parent reply other threads:[~2015-02-28 9:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 7:50 [Qemu-devel] [PATCH 0/9] Coverity defects fixes arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 1/9] nbd: fix resource leak arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 2/9] arm: fix memory leak arei.gonglei
2015-02-28 9:52 ` Michael Tokarev
2015-02-28 9:59 ` Gonglei
2015-02-28 10:18 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2015-02-28 10:21 ` Gonglei
2015-03-04 13:16 ` Michael Tokarev
2015-03-05 2:26 ` Gonglei
2015-03-05 8:47 ` Markus Armbruster
2015-03-05 9:43 ` Gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 3/9] sparc/leon3.c: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 4/9] macio: fix possible " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 5/9] e500: fix " arei.gonglei
2015-02-28 9:41 ` Michael Tokarev
2015-02-28 9:57 ` Gonglei [this message]
2015-02-27 7:50 ` [Qemu-devel] [PATCH 6/9] 9pfs: " arei.gonglei
2015-02-28 9:46 ` Michael Tokarev
2015-03-04 12:30 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2015-02-27 7:50 ` [Qemu-devel] [PATCH 7/9] milkymist.c: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 8/9] sysbus: " arei.gonglei
2015-02-27 7:50 ` [Qemu-devel] [PATCH 9/9] microblaze: " arei.gonglei
2015-02-28 9:54 ` [Qemu-devel] [PATCH 0/9] Coverity defects fixes Michael Tokarev
2015-02-28 10:03 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F19110.7080902@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).