From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRe9z-0000Md-9t for qemu-devel@nongnu.org; Sat, 28 Feb 2015 04:58:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRe9y-0004WA-FB for qemu-devel@nongnu.org; Sat, 28 Feb 2015 04:58:11 -0500 Message-ID: <54F19110.7080902@huawei.com> Date: Sat, 28 Feb 2015 17:57:36 +0800 From: Gonglei MIME-Version: 1.0 References: <1425023419-12244-1-git-send-email-arei.gonglei@huawei.com> <1425023419-12244-6-git-send-email-arei.gonglei@huawei.com> <54F18D2E.1060501@msgid.tls.msk.ru> In-Reply-To: <54F18D2E.1060501@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/9] e500: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, peter.huangpeng@huawei.com, armbru@redhat.com On 2015/2/28 17:41, Michael Tokarev wrote: > 27.02.2015 10:50, arei.gonglei@huawei.com wrote: >> From: Gonglei >> >> Signed-off-by: Gonglei >> --- >> hw/ppc/e500.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c >> index 7e17d18..38203a6 100644 >> --- a/hw/ppc/e500.c >> +++ b/hw/ppc/e500.c >> @@ -542,6 +542,7 @@ done: >> >> out: >> g_free(pci_map); >> + g_free(filename); > > This patch breaks compilation, because `filename' variable is > local to the "if (dtb_file)" code block at the beginning of this > function and shold be freed there. > Yes, it is. Thanks for your review, I'll respin it. Regards, -Gonglei