From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>,
arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] e500: fix memory leak
Date: Sun, 01 Mar 2015 11:06:14 +0100 [thread overview]
Message-ID: <54F2E496.7000700@redhat.com> (raw)
In-Reply-To: <54F1F13C.9070204@weilnetz.de>
On 28/02/2015 17:47, Stefan Weil wrote:
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Which one of the two patch variants did you review?
>
> I suggest using Michael's version (only one g_free as early as
> possible). For that variant, my review may be added:
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
I also referred to Michael's.
Paolo
next prev parent reply other threads:[~2015-03-01 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 10:08 [Qemu-devel] [PATCH v2] e500: fix memory leak arei.gonglei
2015-02-28 10:13 ` Michael Tokarev
2015-02-28 10:18 ` Gonglei
2015-02-28 10:47 ` Michael Tokarev
2015-02-28 16:40 ` Paolo Bonzini
2015-02-28 16:47 ` Stefan Weil
2015-03-01 10:06 ` Paolo Bonzini [this message]
2015-03-02 1:17 ` Gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F2E496.7000700@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).