qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute
Date: Mon, 02 Mar 2015 14:04:14 +0300	[thread overview]
Message-ID: <54F443AE.2000708@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425215915-26043-1-git-send-email-sw@weilnetz.de>

01.03.2015 16:18, Stefan Weil wrote:
> Warnings from the Sparse static analysis tool:
[...]
> @@ -738,7 +737,9 @@ get_field_special (long instr, struct op_code_struct * op)
>     default :
>       {
>         if ( ((((instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) & 0xE000) == REG_PVR_MASK) {
> -	 sprintf(tmpstr, "%spvr%d", register_prefix, (unsigned short)(((instr & IMM_MASK) >> IMM_LOW) ^ op->immval_mask) ^ REG_PVR_MASK);
> +	  sprintf(tmpstr, "%s%u", pvr_register_prefix,
> +                 (unsigned short)(((instr & IMM_MASK) >> IMM_LOW) ^
> +                                  op->immval_mask) ^ REG_PVR_MASK);

Is this word wrapping intentionally put into this patch or
was it supposed to be a separate patch?

Thanks,

/mjt

  reply	other threads:[~2015-03-02 11:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-01 13:18 [Qemu-devel] [PATCH] disas/microblaze: Fix warnings caused by missing 'static' attribute Stefan Weil
2015-03-02 11:04 ` Michael Tokarev [this message]
2015-03-02 11:26   ` Stefan Weil
2015-03-02 12:20 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F443AE.2000708@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).