From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSQcX-0000n0-Up for qemu-devel@nongnu.org; Mon, 02 Mar 2015 08:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSQcS-0005O6-UX for qemu-devel@nongnu.org; Mon, 02 Mar 2015 08:42:53 -0500 Message-ID: <54F468D5.2060407@suse.de> Date: Mon, 02 Mar 2015 14:42:45 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> In-Reply-To: <54F4678D.20909@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , Paolo Bonzini , qemu-ppc , qemu-stable@nongnu.org, kvm Am 02.03.2015 um 14:37 schrieb Alexander Graf: > On 01.03.15 01:31, Andreas F=C3=A4rber wrote: >> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avoid >> double-registration of types: >> >> Registering `POWER5+-powerpc64-cpu' which already exists >> >> Taking the textual description of a CPU type as part of a new type nam= e >> is plain wrong, and so is unconditionally registering a new type here. >> >> Cc: Alexey Kardashevskiy >> Cc: qemu-stable@nongnu.org >> Signed-off-by: Andreas F=C3=A4rber >=20 > Doesn't this break p8 support? Maybe, but p5 support was in longer and this is definitely a regression and really really wrong. If you know a way to fix it without handing it back to the IBM guys for more thought, feel free to give it a shot. Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)