From: Paolo Bonzini <pbonzini@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>, qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com
Subject: Re: [Qemu-devel] commit 0be63901d2a33a6ed25caa5df3f530df75338f6a breaks "-kernel"
Date: Mon, 02 Mar 2015 15:50:28 +0100 [thread overview]
Message-ID: <54F478B4.5090203@redhat.com> (raw)
In-Reply-To: <20150302144150.GD1824@HEDWIG.INI.CMU.EDU>
On 02/03/2015 15:41, Gabriel L. Somlo wrote:
> Using "-kenel <file>" results in a segmentation fault (at least with
> qemu-system-x86_64). Bisect says the breakage was introduced by commit
>
> commit 0be63901d2a33a6ed25caa5df3f530df75338f6a
> Author: Gonglei <arei.gonglei@huawei.com>
> Date: Thu Jan 29 15:08:51 2015 +0800
>
> qdev: support to get a device firmware path directly
>
> commit 6b1566c (qdev: Introduce FWPathProvider interface) did a
> good job for supproting to get firmware path on some different
> architectures.
>
> Moreover further more, we can use the interface to get firmware
> path name for a device which isn't attached a specific bus,
> such as virtio-bus, scsi-bus etc.
>
> When the device (such as vhost-scsi) realize the TYPE_FW_PATH_PROVIDER
> interface, we should introduce a new function to get the correct firmware
> path name for it.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Reverting the commit seems to fix the problem for me, as a temporary
> solution.
Gonglei sent a patch for this, and it's in my pull request from this
morning.
Paolo
prev parent reply other threads:[~2015-03-02 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:41 [Qemu-devel] commit 0be63901d2a33a6ed25caa5df3f530df75338f6a breaks "-kernel" Gabriel L. Somlo
2015-03-02 14:50 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F478B4.5090203@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=gsomlo@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).