From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42874)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YSRgC-0007xT-Qd
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 09:50:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YSRg8-0001wv-Ty
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 09:50:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59929)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YSRg8-0001wp-5c
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 09:50:40 -0500
Message-ID: <54F478B4.5090203@redhat.com>
Date: Mon, 02 Mar 2015 15:50:28 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150302144150.GD1824@HEDWIG.INI.CMU.EDU>
In-Reply-To: <20150302144150.GD1824@HEDWIG.INI.CMU.EDU>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] commit 0be63901d2a33a6ed25caa5df3f530df75338f6a
	breaks "-kernel"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>, qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com



On 02/03/2015 15:41, Gabriel L. Somlo wrote:
> Using "-kenel <file>" results in a segmentation fault (at least with
> qemu-system-x86_64). Bisect says the breakage was introduced by commit
> 
> commit 0be63901d2a33a6ed25caa5df3f530df75338f6a
> Author: Gonglei <arei.gonglei@huawei.com>
> Date:   Thu Jan 29 15:08:51 2015 +0800
> 
>     qdev: support to get a device firmware path directly
>     
>     commit 6b1566c (qdev: Introduce FWPathProvider interface) did a
>     good job for supproting to get firmware path on some different
>     architectures.
>     
>     Moreover further more, we can use the interface to get firmware
>     path name for a device which isn't attached a specific bus,
>     such as virtio-bus, scsi-bus etc.
>     
>     When the device (such as vhost-scsi) realize the TYPE_FW_PATH_PROVIDER
>     interface, we should introduce a new function to get the correct firmware
>     path name for it.
>     
>     Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Reverting the commit seems to fix the problem for me, as a temporary
> solution.

Gonglei sent a patch for this, and it's in my pull request from this
morning.

Paolo