From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com,
lcapitulino@redhat.com, amit.shah@redhat.com,
peter.huangpeng@huawei.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type
Date: Mon, 02 Mar 2015 08:56:15 -0700 [thread overview]
Message-ID: <54F4881F.9080200@redhat.com> (raw)
In-Reply-To: <54F12DD7.6080208@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 02/27/2015 07:54 PM, zhanghailiang wrote:
> On 2015/2/28 0:48, Eric Blake wrote:
>> On 02/26/2015 11:19 PM, zhanghailiang wrote:
>>> The original 'status' is an open-coded 'str' type, convert it to use an
>>> enum type.
>>> +# @MigState:
>>
>> Do we have to abbreviate? I guess leaving it like this makes the rest
>> of the existing code base have less churn (since it matches the spelling
>> of the enum that was previous interanl only), but it might look nicer as
>
> Yes, this is the reason ..., agreed, i don't like the abbreviate,
> But there is already a 'MigrationState' type defined:
>
>
> So, what about MigrationStatus ? ;)
That would be fine with me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-02 15:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 6:19 [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type zhanghailiang
2015-02-27 16:48 ` Eric Blake
2015-02-27 17:07 ` Dr. David Alan Gilbert
2015-02-27 17:42 ` Eric Blake
2015-02-28 3:09 ` zhanghailiang
2015-03-02 15:57 ` Eric Blake
2015-02-28 2:54 ` zhanghailiang
2015-03-02 15:56 ` Eric Blake [this message]
2015-03-03 7:15 ` zhanghailiang
2015-03-03 8:59 ` Dr. David Alan Gilbert
2015-03-04 12:37 ` zhanghailiang
2015-03-04 12:50 ` Dr. David Alan Gilbert
2015-03-04 13:01 ` zhanghailiang
2015-03-03 17:21 ` Eric Blake
2015-03-04 7:48 ` Markus Armbruster
2015-03-04 8:55 ` zhanghailiang
2015-03-04 8:52 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4881F.9080200@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=hangaohuai@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).