From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSShm-00067o-CB for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:56:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSShh-0000B8-EC for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:56:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSShh-0000Ah-4p for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:56:21 -0500 Message-ID: <54F4881F.9080200@redhat.com> Date: Mon, 02 Mar 2015 08:56:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com> <54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com> In-Reply-To: <54F12DD7.6080208@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ohI4epnkTvGUfXpPwvGMdSJOlrFbCGofk" Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ohI4epnkTvGUfXpPwvGMdSJOlrFbCGofk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/27/2015 07:54 PM, zhanghailiang wrote: > On 2015/2/28 0:48, Eric Blake wrote: >> On 02/26/2015 11:19 PM, zhanghailiang wrote: >>> The original 'status' is an open-coded 'str' type, convert it to use = an >>> enum type. >>> +# @MigState: >> >> Do we have to abbreviate? I guess leaving it like this makes the rest= >> of the existing code base have less churn (since it matches the spelli= ng >> of the enum that was previous interanl only), but it might look nicer = as >=20 > Yes, this is the reason ..., agreed, i don't like the abbreviate, > But there is already a 'MigrationState' type defined: >=20 >=20 > So, what about MigrationStatus ? ;) That would be fine with me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ohI4epnkTvGUfXpPwvGMdSJOlrFbCGofk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU9IgfAAoJEKeha0olJ0Nq4aAH/i7JCu8dr3zOUx0YNOhtapeB M0ch1F8+hgMIP/fbABB4ph3GizWr166Q4RQTq/A9/swHmiEnYtJ65A0jDJqkISV8 KvgnymrjOJdGDNlRy5MsSV6gL/57x4q+XmUN97xgrvyRtYm0x95nj/D321bCJpuM 5+5CDZ1+Cg1SR7wUts39iBQVm+JudMlMiQDSTmh9Pc/q1s0pBJHodekfHGjvGisE u2+l4TdH1wuUNksWwrSXLyt+u1/pUmOuHxY4/aDsvBBGfoxr5JJIpEPHKRX3zALq 76xZpd4BSihBizN3KoDVlkHIBt+9GWa7AIlviEsMsHncbRdWeXhvJRVihmK9Two= =NQVa -----END PGP SIGNATURE----- --ohI4epnkTvGUfXpPwvGMdSJOlrFbCGofk--