From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSSww-0001WD-SM for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:12:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSSws-0005je-Rm for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:12:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSSws-0005ja-K9 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 11:12:02 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t22GC10F020001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Mar 2015 11:12:01 -0500 Message-ID: <54F48BCE.1060400@redhat.com> Date: Mon, 02 Mar 2015 11:11:58 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423598552-24301-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1423598552-24301-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi On 2015-02-10 at 15:02, Max Reitz wrote: > Under certain circumstances, making the refcount table grow can result > in leaking clusters. The first patch fixes at least some of those > circumstances (maybe there are more, but these are the ones I am aware > of), and the second patch adds a test case. > > > Max Reitz (2): > qcow2: Respect new_block in alloc_refcount_block() > iotests: Add tests for refcount table growth > > block/qcow2-refcount.c | 16 ++++++- > tests/qemu-iotests/121 | 102 +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/121.out | 23 ++++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 140 insertions(+), 2 deletions(-) > create mode 100755 tests/qemu-iotests/121 > create mode 100644 tests/qemu-iotests/121.out Applied to my block tree: https://github.com/XanClic/qemu/commits/block