From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSTpo-0003Zt-EM for qemu-devel@nongnu.org; Mon, 02 Mar 2015 12:08:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSTpk-0001iU-FV for qemu-devel@nongnu.org; Mon, 02 Mar 2015 12:08:48 -0500 Message-ID: <54F49918.40705@redhat.com> Date: Mon, 02 Mar 2015 12:08:40 -0500 From: Max Reitz MIME-Version: 1.0 References: <1425084477-31602-1-git-send-email-jsnow@redhat.com> <1425084477-31602-8-git-send-email-jsnow@redhat.com> In-Reply-To: <1425084477-31602-8-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RESEND 07/17] block: Add bitmap disabled status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-02-27 at 19:47, John Snow wrote: > Add a status indicating the enabled/disabled state of the bitmap. > A bitmap is by default enabled, but you can lock the bitmap into > a read-only state by setting disabled = true. > > A previous version of this patch added a QMP interface for changing > the state of the bitmap, but it has since been removed for now until > a use case emerges where this state must be revealed to the user. > > The disabled state WILL be used internally for bitmap migration and > bitmap persistence. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block.c | 25 +++++++++++++++++++++++++ > include/block/block.h | 3 +++ > 2 files changed, 28 insertions(+) Reviewed-by: Max Reitz