* [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices
@ 2015-03-02 16:09 Gerd Hoffmann
2015-03-03 1:36 ` Brad Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2015-03-02 16:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Brad Campbell
Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
update_displaychangelistener call sites:
Two for primary qxl cards, when entering/leaving vga mode, which are
correct.
One for secondary qxl cards, which is wrong because we don't register
a displaychangelistener in the first place for secondary cards.
Remove it.
Reported-by: Brad Campbell <lists2009@fnarfbargle.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/qxl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index 94ff52a..762f75d 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
qxl_enter_vga_mode(d);
} else {
d->mode = QXL_MODE_UNDEFINED;
- update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices
2015-03-02 16:09 [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices Gerd Hoffmann
@ 2015-03-03 1:36 ` Brad Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Brad Campbell @ 2015-03-03 1:36 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Brad Campbell
On 03/03/15 00:09, Gerd Hoffmann wrote:
> Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
> update_displaychangelistener call sites:
>
> Two for primary qxl cards, when entering/leaving vga mode, which are
> correct.
>
> One for secondary qxl cards, which is wrong because we don't register
> a displaychangelistener in the first place for secondary cards.
>
> Remove it.
>
> Reported-by: Brad Campbell <lists2009@fnarfbargle.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Brad Campbell <lists2009@fnarfbargle.com>
> ---
> hw/display/qxl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 94ff52a..762f75d 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
> qxl_enter_vga_mode(d);
> } else {
> d->mode = QXL_MODE_UNDEFINED;
> - update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);
> }
> }
>
>
Many thanks for the rapid response Gerd.
Regards,
Brad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-03 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02 16:09 [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener call for secondary qxl devices Gerd Hoffmann
2015-03-03 1:36 ` Brad Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).