From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@fnarfbargle.com>) id 1YSblx-0007YJ-Le
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 20:37:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@fnarfbargle.com>) id 1YSblu-0002pa-GJ
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 20:37:21 -0500
Received: from ns3.fnarfbargle.com ([103.4.17.7]:58543)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@fnarfbargle.com>) id 1YSblu-0002ml-5d
	for qemu-devel@nongnu.org; Mon, 02 Mar 2015 20:37:18 -0500
Message-ID: <54F51000.8090406@fnarfbargle.com>
Date: Tue, 03 Mar 2015 09:36:00 +0800
From: Brad Campbell <brad@fnarfbargle.com>
MIME-Version: 1.0
References: <1425312553-19877-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1425312553-19877-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl: drop update_displaychangelistener
 call for secondary qxl devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Brad Campbell <lists2009@fnarfbargle.com>

On 03/03/15 00:09, Gerd Hoffmann wrote:
> Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
> update_displaychangelistener call sites:
>
> Two for primary qxl cards, when entering/leaving vga mode, which are
> correct.
>
> One for secondary qxl cards, which is wrong because we don't register
> a displaychangelistener in the first place for secondary cards.
>
> Remove it.
>
> Reported-by: Brad Campbell <lists2009@fnarfbargle.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Brad Campbell <lists2009@fnarfbargle.com>

> ---
>   hw/display/qxl.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 94ff52a..762f75d 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -1147,7 +1147,6 @@ static void qxl_soft_reset(PCIQXLDevice *d)
>           qxl_enter_vga_mode(d);
>       } else {
>           d->mode = QXL_MODE_UNDEFINED;
> -        update_displaychangelistener(&d->ssd.dcl, GUI_REFRESH_INTERVAL_IDLE);
>       }
>   }
>
>

Many thanks for the rapid response Gerd.

Regards,
Brad