From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YSh4v-00085Y-Ua
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 02:17:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YSh4s-00056H-OO
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 02:17:17 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:28514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YSh4s-00055S-1U
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 02:17:14 -0500
Message-ID: <54F55F8D.7040403@huawei.com>
Date: Tue, 3 Mar 2015 15:15:25 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com>
	<54F4881F.9080200@redhat.com>
In-Reply-To: <54F4881F.9080200@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of
 MigrationInfo to use an enum type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com

On 2015/3/2 23:56, Eric Blake wrote:
> On 02/27/2015 07:54 PM, zhanghailiang wrote:
>> On 2015/2/28 0:48, Eric Blake wrote:
>>> On 02/26/2015 11:19 PM, zhanghailiang wrote:
>>>> The original 'status' is an open-coded 'str' type, convert it to use an
>>>> enum type.
>
>>>> +# @MigState:
>>>
>>> Do we have to abbreviate?  I guess leaving it like this makes the rest
>>> of the existing code base have less churn (since it matches the spelling
>>> of the enum that was previous interanl only), but it might look nicer as
>>
>> Yes, this is the reason ..., agreed, i don't like the abbreviate,
>> But there is already a 'MigrationState' type defined:
>>
>
>>
>> So, what about MigrationStatus ? ;)
>
> That would be fine with me.
>

Bad news, this name has also been used :(

In hmp.c:

typedef struct MigrationStatus
{
     QEMUTimer *timer;
     Monitor *mon;
     bool is_block_migration;
} MigrationStatus