From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSjEs-00022b-1q for qemu-devel@nongnu.org; Tue, 03 Mar 2015 04:35:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSjEq-0004F5-VG for qemu-devel@nongnu.org; Tue, 03 Mar 2015 04:35:41 -0500 Message-ID: <54F5801A.2090109@huawei.com> Date: Tue, 3 Mar 2015 17:34:18 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1425114327-12136-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425114327-12136-6-git-send-email-zhang.zhanghailiang@huawei.com> <874mq3hf0b.fsf@blackfin.pond.sub.org> <54F550AB.4040607@huawei.com> <87sidm780f.fsf@blackfin.pond.sub.org> In-Reply-To: <87sidm780f.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 5/5] savevm: Replace error_report() & error_free() with error_report_err() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, hangaohuai@huawei.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org On 2015/3/3 17:19, Markus Armbruster wrote: > zhanghailiang writes: > >> On 2015/3/2 18:26, Markus Armbruster wrote: >>> zhanghailiang writes: >>> >>>> Signed-off-by: zhanghailiang >>>> --- >>>> savevm.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/savevm.c b/savevm.c >>>> index ce2b6a2..c4f8c39 100644 >>>> --- a/savevm.c >>>> +++ b/savevm.c >>>> @@ -932,8 +932,7 @@ int qemu_loadvm_state(QEMUFile *f) >>>> int ret; >>>> >>>> if (qemu_savevm_state_blocked(&local_err)) { >>>> - error_report("%s", error_get_pretty(local_err)); >>>> - error_free(local_err); >>>> + error_report_err(local_err); >>>> return -EINVAL; >>>> } >>> >>> This one's good. My commit 565f65d "error: Use error_report_err() where >>> appropriate" cleaned up this pattern, but a few more instances have >>> since crept in, and this is one. >>> >>> I can see another one in hw/arm/virt.c machvirt_init(). >>> >>> >> >> Er, do you mean the follow place ? >> >> /* Handle any CPU options specified by the user */ >> cc->parse_features(CPU(cpuobj), cpustr[1], &err); >> if (err) { >> error_report("%s", error_get_pretty(err)); >> exit(1); >> } > > Yes. OK, i will send a patch fix these two places. Thanks. :)