From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSkCt-00028K-Cn for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSkCn-0006u9-UB for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:37:43 -0500 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:44482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSkCn-0006u2-O2 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 05:37:37 -0500 Received: by wiwl15 with SMTP id l15so21566590wiw.3 for ; Tue, 03 Mar 2015 02:37:37 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54F58EEE.3070604@redhat.com> Date: Tue, 03 Mar 2015 11:37:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <33183CC9F5247A488A2544077AF1902086E48F40@SZXEMA503-MBS.china.huawei.com> <54F588D7.6060804@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Bug ?]Qemu segfault because of non-initial kvm_state variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Gonglei (Arei)" , "qemu-devel@nongnu.org" On 03/03/2015 11:21, Peter Maydell wrote: > On 3 March 2015 at 19:11, Paolo Bonzini wrote: >> >> >> On 03/03/2015 09:01, Gonglei (Arei) wrote: >>> Hi, >>> >>> I encountered a Qemu segfault problem in my environment. >>> >>> # ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 -drive file=/home/win2008_ent_r2_64_01,\ >>> if=none,id=drive-ide0-0-0 -device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 -vnc :10 >>> Segmentation fault >> >> Should be fixed by: >> >> diff --git a/kvm-all.c b/kvm-all.c >> index 05a79c2..e04a0ca 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -1679,7 +1679,7 @@ void kvm_flush_coalesced_mmio_buffer(void) >> { >> KVMState *s = kvm_state; >> >> - if (s->coalesced_flush_in_progress) { >> + if (!s || s->coalesced_flush_in_progress) { >> return; >> } > > Is it worth my holding off on applying further pullreqs til > we apply this fix to master (in the interests of future > bisectability), or does it not affect many people/configs? I've sent the patch as message-id 1425378961-9600-1-git-send-email-pbonzini@redhat.com now. You can apply it directly or I can send a pull request. However, the patch depends on my other pending pull request ("[PULL 00/15] Misc changes for 2015-03-02"). Paolo