From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSndg-0000Bi-Jt for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:17:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSndc-00026C-NE for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:17:36 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:48328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSndc-00025n-Cr for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:17:32 -0500 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2015 14:17:30 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id B4031219005C for ; Tue, 3 Mar 2015 14:17:19 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t23EHRFj4063724 for ; Tue, 3 Mar 2015 14:17:27 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t23EHRR3025844 for ; Tue, 3 Mar 2015 07:17:27 -0700 Message-ID: <54F5C276.4030908@de.ibm.com> Date: Tue, 03 Mar 2015 15:17:26 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <20150302092822.GB4443@noname.redhat.com> <1425370526-15215-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1425370526-15215-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add testcase for scsi-hd devices without drive property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kwolf@redhat.com Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org, tumanova@linux.vnet.ibm.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, mreitz@redhat.com Am 03.03.2015 um 09:15 schrieb Christian Borntraeger: > CC: Max Reitz > Suggested-by: Kevin Wolf > Signed-off-by: Christian Borntraeger > --- > tests/qemu-iotests/051 | 9 +++++++++ > tests/qemu-iotests/051.out | 8 ++++++++ > 2 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 > index 11c858f..1eec350 100755 > --- a/tests/qemu-iotests/051 > +++ b/tests/qemu-iotests/051 > @@ -95,6 +95,15 @@ run_qemu -drive file="$TEST_IMG",driver=foo > run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2 > > echo > +echo === Device without drive === > +echo > + > +# virtio-scsi-pci, virtio-scsi-ccw, virtio-scsi-s390... > +VIRTSCSIDEV=`${QEMU} -device help 2>&1 | grep -v virtio-scsi-device | grep -m 1 virtio-scsi | cut -d \" -f 2` > + Hmmm. Doesnt work reliably on s390. > +run_qemu -device ${VIRTSCSIDEV} -device scsi-hd Maybe we can just use virtio-scsi-pci hardcoded and fixup s390 later on as there are other io tests in here that need some special s390 changes as well. (We are working on it) So something like diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 11c858f..6ab40e2 100755 --- a/tests/qemu-iotests/051 +++ b/tests/qemu-iotests/051 @@ -95,6 +95,12 @@ run_qemu -drive file="$TEST_IMG",driver=foo run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2 echo +echo === Device without drive === +echo + +run_qemu -device virtio-scsi-pci -device scsi-hd + +echo echo === Overriding backing file === echo plus the test output. Makes sense? Christian