From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YSnrf-00074r-0a
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:32:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YSnra-0004bH-QB
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:32:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YSnra-0004au-I9
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 09:31:58 -0500
Message-ID: <54F5C5D4.2000903@redhat.com>
Date: Tue, 03 Mar 2015 09:31:48 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <20150302092822.GB4443@noname.redhat.com>
	<1425370526-15215-1-git-send-email-borntraeger@de.ibm.com>
	<54F5C276.4030908@de.ibm.com>
In-Reply-To: <54F5C276.4030908@de.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Add testcase for scsi-hd devices without
	drive property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>, kwolf@redhat.com
Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org, tumanova@linux.vnet.ibm.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com

On 2015-03-03 at 09:17, Christian Borntraeger wrote:
> Am 03.03.2015 um 09:15 schrieb Christian Borntraeger:
>> CC: Max Reitz <mreitz@redhat.com>
>> Suggested-by: Kevin Wolf <kwolf@redhat.com>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>   tests/qemu-iotests/051     |    9 +++++++++
>>   tests/qemu-iotests/051.out |    8 ++++++++
>>   2 files changed, 17 insertions(+), 0 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
>> index 11c858f..1eec350 100755
>> --- a/tests/qemu-iotests/051
>> +++ b/tests/qemu-iotests/051
>> @@ -95,6 +95,15 @@ run_qemu -drive file="$TEST_IMG",driver=foo
>>   run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2
>>
>>   echo
>> +echo === Device without drive ===
>> +echo
>> +
>> +# virtio-scsi-pci, virtio-scsi-ccw, virtio-scsi-s390...
>> +VIRTSCSIDEV=`${QEMU} -device help 2>&1 | grep -v virtio-scsi-device | grep -m 1 virtio-scsi | cut -d \" -f 2`
>> +
> Hmmm. Doesnt work reliably on s390.
>
>
>> +run_qemu -device ${VIRTSCSIDEV} -device scsi-hd
> Maybe we can just use virtio-scsi-pci hardcoded and fixup s390 later on as
> there are other io tests in here that need some special s390 changes as well.
> (We are working on it)
>
> So something like
>
> diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
> index 11c858f..6ab40e2 100755
> --- a/tests/qemu-iotests/051
> +++ b/tests/qemu-iotests/051
> @@ -95,6 +95,12 @@ run_qemu -drive file="$TEST_IMG",driver=foo
>   run_qemu -drive file="$TEST_IMG",driver=raw,format=qcow2
>   
>   echo
> +echo === Device without drive ===
> +echo
> +
> +run_qemu -device virtio-scsi-pci -device scsi-hd
> +
> +echo
>   echo === Overriding backing file ===
>   echo
>
>
> plus the test  output. Makes sense?

Fine with me.

Max