From: Max Reitz <mreitz@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>, kwolf@redhat.com
Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org,
tumanova@linux.vnet.ibm.com, armbru@redhat.com,
mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com,
stefanha@redhat.com, cornelia.huck@de.ibm.com
Subject: Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property
Date: Tue, 03 Mar 2015 10:19:17 -0500 [thread overview]
Message-ID: <54F5D0F5.2030406@redhat.com> (raw)
In-Reply-To: <1425394766-12450-1-git-send-email-borntraeger@de.ibm.com>
On 2015-03-03 at 09:59, Christian Borntraeger wrote:
> Lets add a test for scsi devices without a drive. This was broken
> by a recent block patch, thus indicating that we need a testcase.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> tests/qemu-iotests/051 | 6 ++++++
> tests/qemu-iotests/051.out | 8 ++++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
I think we should wait with applying this patch until the relevant patch
to scsi-disk.c is applied, though (I'm not completely opposed to
applying patches that fail from the start, but it does make bisecting
more difficult).
Max
next prev parent reply other threads:[~2015-03-03 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 14:59 [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property Christian Borntraeger
2015-03-03 15:19 ` Max Reitz [this message]
2015-03-03 22:23 ` Stefan Hajnoczi
2015-03-04 12:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5D0F5.2030406@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dahi@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).