From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSobj-0003lf-J5 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:19:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSobe-0000GM-K1 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:19:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSobe-0000G9-C7 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:19:34 -0500 Message-ID: <54F5D0F5.2030406@redhat.com> Date: Tue, 03 Mar 2015 10:19:17 -0500 From: Max Reitz MIME-Version: 1.0 References: <1425394766-12450-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1425394766-12450-1-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2] Add testcase for scsi-hd devices without drive property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , kwolf@redhat.com Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org, tumanova@linux.vnet.ibm.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com On 2015-03-03 at 09:59, Christian Borntraeger wrote: > Lets add a test for scsi devices without a drive. This was broken > by a recent block patch, thus indicating that we need a testcase. > > Suggested-by: Kevin Wolf > Signed-off-by: Christian Borntraeger > --- > tests/qemu-iotests/051 | 6 ++++++ > tests/qemu-iotests/051.out | 8 ++++++++ > 2 files changed, 14 insertions(+), 0 deletions(-) Reviewed-by: Max Reitz I think we should wait with applying this patch until the relevant patch to scsi-disk.c is applied, though (I'm not completely opposed to applying patches that fail from the start, but it does make bisecting more difficult). Max