From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSoig-0001g2-RM for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:26:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSoia-0004Ge-Nr for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:26:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSoia-0004GJ-H6 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 10:26:44 -0500 Message-ID: <54F5D2B1.10405@redhat.com> Date: Tue, 03 Mar 2015 10:26:41 -0500 From: Cole Robinson MIME-Version: 1.0 References: <1425371482-25590-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1425371482-25590-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hmp: info spice: take out webdav List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: spice-devel@lists.freedesktop.org, Luiz Capitulino On 03/03/2015 03:31 AM, Gerd Hoffmann wrote: > Obvious suggestion for the next spice-protocol > release: Add some way to #ifdef new stuff. > > Signed-off-by: Gerd Hoffmann > --- > hmp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hmp.c b/hmp.c > index eacfb1b..71c28bc 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -561,7 +561,12 @@ void hmp_info_spice(Monitor *mon, const QDict *qdict) > [SPICE_CHANNEL_SMARTCARD] = "smartcard", > [SPICE_CHANNEL_USBREDIR] = "usbredir", > [SPICE_CHANNEL_PORT] = "port", > +#if 0 > + /* minimum spice-protocol is 0.12.3, webdav was added in 0.12.7, > + * no easy way to #ifdef (SPICE_CHANNEL_* is a enum). Disable > + * as quick fix for build failures with older versions. */ > [SPICE_CHANNEL_WEBDAV] = "webdav", > +#endif > }; > > info = qmp_query_spice(NULL); > Hmm sorry about that. Reviewed-by: Cole Robinson - Cole