From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqW8-0005gr-Q7 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSqW6-0003jA-28 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:22:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqW5-0003iz-QR for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:21:58 -0500 Message-ID: <54F5EDAF.7090501@redhat.com> Date: Tue, 03 Mar 2015 10:21:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com> <54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com> <54F4881F.9080200@redhat.com> <54F55F8D.7040403@huawei.com> In-Reply-To: <54F55F8D.7040403@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oO3TUGIBMkKKKcKqtguS4AioWeiTFLPKH" Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oO3TUGIBMkKKKcKqtguS4AioWeiTFLPKH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/03/2015 12:15 AM, zhanghailiang wrote: >>> >>> Yes, this is the reason ..., agreed, i don't like the abbreviate, >>> But there is already a 'MigrationState' type defined: >>> >> >>> >>> So, what about MigrationStatus ? ;) >> >> That would be fine with me. >> >=20 > Bad news, this name has also been used :( >=20 > In hmp.c: >=20 > typedef struct MigrationStatus You know, you could always rename the internal-only conflict into something else so that the publicly exported typename is nice. Yeah, that makes the series longer, but it should be all mechanical conversions, right? I'm not going to be too picky about what color we paint this bikeshed, though. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oO3TUGIBMkKKKcKqtguS4AioWeiTFLPKH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU9e2vAAoJEKeha0olJ0NqKWYH/ifrI3CZcmUnaELSfdNGGZzu uNerZWTXRJlvBvGou2ZSBJ/lQzhoWhBSnmL7/cWXZVHnc1mVbxmSTsx9XS+xR6FJ 5SGYJTKXybL22QPw+fLQs/6Vi5LDn1fqgf+8uTZD6A17L5IdWy9S8ygVQDFengh9 mI5xsbbEJ4/AoM5aQ948ehq1N6aZ6KsKC/Lol55Cm9ztLvNSV+zCVvfYlTGdvLtO uqZU06GlJrJLSJ4eB6uOkhmcKvMzavT3FYQY3krvDqkqJPe05SN40bVH+/Ir24hu +dXdNLE43JiNLqHi65YALK9hiTcq1R+JVo+JXo4n6uy1iQqUmx2Y0E0/AzUtI6o= =FnRb -----END PGP SIGNATURE----- --oO3TUGIBMkKKKcKqtguS4AioWeiTFLPKH--