From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqdu-0000JF-Ch for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:30:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSqdr-0006Xo-Ly for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:30:02 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:35788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqdr-0006XN-Bl for qemu-devel@nongnu.org; Tue, 03 Mar 2015 12:29:59 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2015 17:29:57 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id EF23D17D8059 for ; Tue, 3 Mar 2015 17:30:12 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t23HTrgu64684246 for ; Tue, 3 Mar 2015 17:29:53 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t23HTqVO028175 for ; Tue, 3 Mar 2015 10:29:53 -0700 Message-ID: <54F5EF8F.7000802@de.ibm.com> Date: Tue, 03 Mar 2015 18:29:51 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1425061147-1411-1-git-send-email-stefanha@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/69] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stefan Hajnoczi Cc: qemu-devel , Stefan Hajnoczi Am 03.03.2015 um 15:52 schrieb Peter Maydell: > On 28 February 2015 at 03:57, Stefan Hajnoczi wrote: >> On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi wrote: >>> Ekaterina Tumanova (5): >>> block: add bdrv functions for geometry and blocksize >>> raw-posix: Factor block size detection out of raw_probe_alignment() >>> block: Add driver methods to probe blocksizes and geometry >>> block-backend: Add wrappers for blocksizes and geometry probing >>> BlockConf: Call backend functions to detect geometry and blocksizes >> >> Max Reitz found an issue with this patch. >> >> Peter: Please squash the following trivial fix into "BlockConf: Call >> backend functions to detect geometry and blocksizes": >> https://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg05512.html > > I can't squash fixes into pull requests -- I can only > apply them, or not apply them. You need to respin. > >> I want to avoid spamming the list with another 60 patches. > > If it's a trivial change since last time around you can just > send the cover letter to the list with a note in it that there > have only been small changes. > > -- PMM > I think you could just apply this pull request and add the fixup as separate patch. After all it fixes a case were the command line is wrong, so should not on the critical path - I guess. Christian