qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Oliver Francke <Oliver.Francke@filoo.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vl: take iothread lock very early
Date: Tue, 03 Mar 2015 18:32:39 +0100	[thread overview]
Message-ID: <54F5F037.1000703@redhat.com> (raw)
In-Reply-To: <54F5ED16.4090803@filoo.de>



On 03/03/2015 18:19, Oliver Francke wrote:
> 
> #0  __GI_exit (status=1) at exit.c:104
> #1  0x000055555575cf15 in os_daemonize () at os-posix.c:227
> #2  0x0000555555773f2e in main (argc=50, argv=0x7fffffffe0d8,
> envp=0x7fffffffe270) at vl.c:3770
> 
> compiled with "--enable-debug" and in gdb "b exit". Not a coder, so if
> this is _not_ sufficient, please give me some adivce ;)

Try removing -daemonize (hmm, that might actually fix the bug).  You
should not need "b exit", because the error is a SIGABRT and gdb stops
automatically.  The fix could be something like this:

diff --git a/vl.c b/vl.c
index e1ffd0a..af61835 100644
--- a/vl.c
+++ b/vl.c
@@ -3759,7 +3759,9 @@ int main(int argc, char **argv, char **envp)

     loc_set_none();

+    qemu_mutex_unlock_iothread();
     os_daemonize();
+    qemu_mutex_lock_iothread();

     if (qemu_init_main_loop(&main_loop_err)) {
         error_report_err(main_loop_err);

Paolo

  reply	other threads:[~2015-03-03 17:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 10:36 [Qemu-devel] [PATCH] vl: take iothread lock very early Paolo Bonzini
2015-03-03 11:13 ` Christian Borntraeger
2015-03-03 11:29 ` Gonglei
2015-03-03 13:43 ` Peter Maydell
2015-03-03 16:03 ` Oliver Francke
2015-03-03 16:51   ` Paolo Bonzini
2015-03-03 17:19     ` Oliver Francke
2015-03-03 17:32       ` Paolo Bonzini [this message]
2015-03-03 18:02         ` Oliver Francke
2015-03-04 22:20         ` Christian Borntraeger
2015-03-05  0:40         ` Eric Blake
2015-03-05 10:07           ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F5F037.1000703@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Oliver.Francke@filoo.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).