From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YStfb-0002Do-9n for qemu-devel@nongnu.org; Tue, 03 Mar 2015 15:44:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YStfX-0000Dy-A0 for qemu-devel@nongnu.org; Tue, 03 Mar 2015 15:43:59 -0500 Message-ID: <54F61D09.2020601@suse.de> Date: Tue, 03 Mar 2015 21:43:53 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1425169895-10783-1-git-send-email-afaerber@suse.de> <54F4678D.20909@suse.de> <54F468D5.2060407@suse.de> <54F46AF7.60209@suse.de> <54F50366.6080105@ozlabs.ru> In-Reply-To: <54F50366.6080105@ozlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Revert "target-ppc: Create versionless CPU class per family if KVM" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc , qemu-stable@nongnu.org, kvm On 03.03.15 01:42, Alexey Kardashevskiy wrote: > On 03/03/2015 12:51 AM, Alexander Graf wrote: >> >> >> On 02.03.15 14:42, Andreas F=C3=A4rber wrote: >>> Am 02.03.2015 um 14:37 schrieb Alexander Graf: >>>> On 01.03.15 01:31, Andreas F=C3=A4rber wrote: >>>>> This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avo= id >>>>> double-registration of types: >>>>> >>>>> Registering `POWER5+-powerpc64-cpu' which already exists >>>>> >>>>> Taking the textual description of a CPU type as part of a new type >>>>> name >>>>> is plain wrong, and so is unconditionally registering a new type he= re. >>>>> >>>>> Cc: Alexey Kardashevskiy >>>>> Cc: qemu-stable@nongnu.org >>>>> Signed-off-by: Andreas F=C3=A4rber >>>> >>>> Doesn't this break p8 support? >>> >>> Maybe, but p5 support was in longer and this is definitely a regressi= on >>> and really really wrong. If you know a way to fix it without handing = it >>> back to the IBM guys for more thought, feel free to give it a shot. >> >> I honestly don't fully remember what this was about. Wasn't this our >> special KVM class that we use to create a compatible cpu type on the f= ly? >> >> Alexey, please take a look at it. >=20 >=20 > I sent a note yesterday :-/ Here it is again: >=20 > With this revert, running qemu with HV KVM and -cpu POWER7 fails on rea= l > POWER7 machine as my machine has pvr 003f 0201 and POWER7 is an alias o= f > POWER7_v2.3 (pvr 003f 0203); and this is what I tried to fix at the > first place. QEMU looks at classes first, and if not found - at aliases= , > so this worked. >=20 > I would rename "POWER5+" to "POWER5+_0.0" and make "POWER5+" an alias > for POWER5+_v2.1 (or POWER5+_0.0). Care to send a patch? Alex