From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YSv1S-0007j2-FS
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 17:10:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YSv1O-0002bZ-Ek
	for qemu-devel@nongnu.org; Tue, 03 Mar 2015 17:10:38 -0500
Message-ID: <54F63154.1070506@redhat.com>
Date: Tue, 03 Mar 2015 17:10:28 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1425417759-17170-1-git-send-email-mreitz@redhat.com>
	<1425417759-17170-2-git-send-email-mreitz@redhat.com>
	<54F63035.3080000@redhat.com>
In-Reply-To: <54F63035.3080000@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] iotests: Remove 006
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-03-03 at 17:05, Eric Blake wrote:
> On 03/03/2015 02:22 PM, Max Reitz wrote:
>> vpc does support images > 127 GB if done correctly. qemu does it
>> correctly. Remove the test pretending otherwise.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/006     | 54 ----------------------------------------------
>>   tests/qemu-iotests/006.out |  6 ------
>>   tests/qemu-iotests/group   |  2 +-
>>   3 files changed, 1 insertion(+), 61 deletions(-)
>>   delete mode 100755 tests/qemu-iotests/006
>>   delete mode 100644 tests/qemu-iotests/006.out
> Should the test be rewritten instead to test that we can create and open
> such a file?  But I'm also okay with your decision to nuke it entirely.

Well, in order to test it correctly, we'd have to check whether the CHS 
configuration is set to 65535/16/255 (as the specification dictates); 
because that was the purpose of the test, that we cannot exceed that 
limit (whereas in fact we can).

Dropping is easier, so that's what I did.

> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

Max