From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: hangaohuai@huawei.com, quintela@redhat.com, armbru@redhat.com,
lcapitulino@redhat.com, amit.shah@redhat.com,
peter.huangpeng@huawei.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type
Date: Wed, 4 Mar 2015 16:52:34 +0800 [thread overview]
Message-ID: <54F6C7D2.2020500@huawei.com> (raw)
In-Reply-To: <54F5EDAF.7090501@redhat.com>
On 2015/3/4 1:21, Eric Blake wrote:
> On 03/03/2015 12:15 AM, zhanghailiang wrote:
>
>>>>
>>>> Yes, this is the reason ..., agreed, i don't like the abbreviate,
>>>> But there is already a 'MigrationState' type defined:
>>>>
>>>
>>>>
>>>> So, what about MigrationStatus ? ;)
>>>
>>> That would be fine with me.
>>>
>>
>> Bad news, this name has also been used :(
>>
>> In hmp.c:
>>
>> typedef struct MigrationStatus
>
> You know, you could always rename the internal-only conflict into
> something else so that the publicly exported typename is nice. Yeah,
> that makes the series longer, but it should be all mechanical
OK, I will try ..., Thanks. :)
> conversions, right? I'm not going to be too picky about what color we
> paint this bikeshed, though.
>
prev parent reply other threads:[~2015-03-04 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 6:19 [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type zhanghailiang
2015-02-27 16:48 ` Eric Blake
2015-02-27 17:07 ` Dr. David Alan Gilbert
2015-02-27 17:42 ` Eric Blake
2015-02-28 3:09 ` zhanghailiang
2015-03-02 15:57 ` Eric Blake
2015-02-28 2:54 ` zhanghailiang
2015-03-02 15:56 ` Eric Blake
2015-03-03 7:15 ` zhanghailiang
2015-03-03 8:59 ` Dr. David Alan Gilbert
2015-03-04 12:37 ` zhanghailiang
2015-03-04 12:50 ` Dr. David Alan Gilbert
2015-03-04 13:01 ` zhanghailiang
2015-03-03 17:21 ` Eric Blake
2015-03-04 7:48 ` Markus Armbruster
2015-03-04 8:55 ` zhanghailiang
2015-03-04 8:52 ` zhanghailiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6C7D2.2020500@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=hangaohuai@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).