From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT9p8-00018p-Az for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT9p5-0007I4-HK for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:58:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT9p5-0007Hu-A2 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 08:58:51 -0500 Message-ID: <54F70F91.8080507@redhat.com> Date: Wed, 04 Mar 2015 08:58:41 -0500 From: Max Reitz MIME-Version: 1.0 References: <1425463336-20660-1-git-send-email-tumanova@linux.vnet.ibm.com> <20150304122327.GJ3465@noname.str.redhat.com> In-Reply-To: <20150304122327.GJ3465@noname.str.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Ekaterina Tumanova Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, armbru@redhat.com, stefanha@redhat.com, borntraeger@de.ibm.com On 2015-03-04 at 07:23, Kevin Wolf wrote: > Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben: >> commit "BlockConf: Call backend functions to detect geometry and >> blocksizes" causes a segmentation fault on the invalid configuration of >> a scsi device without a drive. >> >> Lets check for conf.blk before calling blkconf_blocksizes. The error >> will be handled later on in scsi_realize anyway. >> >> Reported-by: Max Reitz >> Reviewed-by: Stefan Hajnoczi >> Reviewed-by: Max Reitz >> Signed-off-by: Ekaterina Tumanova > Thanks, added the commit ID of the regression to the commit message, and > applied to the block branch. But that commit is not yet upstream, so the ID won't be stable. Are you planning to change it once it's merged? Max