From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT9sh-0006xH-7O for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:02:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT9se-0000oM-By for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:02:35 -0500 Message-ID: <54F71073.1090404@redhat.com> Date: Wed, 04 Mar 2015 09:02:27 -0500 From: Max Reitz MIME-Version: 1.0 References: <1425413591-31413-1-git-send-email-mreitz@redhat.com> <1425413591-31413-4-git-send-email-mreitz@redhat.com> <20150304063032.GC19563@ad.nay.redhat.com> In-Reply-To: <20150304063032.GC19563@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 03/13] iotests: Add test for eject under NBD server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini On 2015-03-04 at 01:30, Fam Zheng wrote: > On Tue, 03/03 15:13, Max Reitz wrote: >> This patch adds a test for ejecting the BlockBackend an NBD server is >> connected to (the NBD server is supposed to stop). >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/096 | 90 ++++++++++++++++++++++++++++++++++++++++++++++ >> tests/qemu-iotests/096.out | 16 +++++++++ >> tests/qemu-iotests/group | 1 + >> 3 files changed, 107 insertions(+) >> create mode 100755 tests/qemu-iotests/096 >> create mode 100644 tests/qemu-iotests/096.out >> >> diff --git a/tests/qemu-iotests/096 b/tests/qemu-iotests/096 >> new file mode 100755 >> index 0000000..bcba0ec >> --- /dev/null >> +++ b/tests/qemu-iotests/096 >> @@ -0,0 +1,90 @@ >> +#!/bin/bash >> +# >> +# Test case for ejecting a BB with an NBD server attached to it >> +# >> +# Copyright (C) 2015 Red Hat, Inc. >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 2 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program. If not, see . >> +# >> + >> +# creator >> +owner=mreitz@redhat.com >> + >> +seq="$(basename $0)" >> +echo "QA output created by $seq" >> + >> +here="$PWD" >> +tmp=/tmp/$$ >> +status=1 # failure is the default! >> + >> +_cleanup() >> +{ >> + _cleanup_test_img >> +} >> +trap "_cleanup; exit \$status" 0 1 2 3 15 >> + >> +# get standard environment, filters and checks >> +. ./common.rc >> +. ./common.filter >> +. ./common.qemu >> + >> +_supported_fmt generic >> +_supported_proto file >> +_supported_os Linux >> + >> +_make_test_img 64k >> + >> +$QEMU_IO -c 'write -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io >> + >> +keep_stderr=y \ >> +_launch_qemu -drive if=ide,media=cdrom,id=drv,file="$TEST_IMG",format=$IMGFMT \ >> + 2> >(_filter_nbd) >> + >> +_send_qemu_cmd $QEMU_HANDLE \ >> + "{ 'execute': 'qmp_capabilities' }" \ >> + 'return' >> + >> +_send_qemu_cmd $QEMU_HANDLE \ >> + "{ 'execute': 'nbd-server-start', >> + 'arguments': { 'addr': { 'type': 'inet', >> + 'data': { 'host': '127.0.0.1', >> + 'port': '10809' }}}}" \ > Why not nbd+unix? The port could be unavailable. Running the iotests for NBD does use TCP/IP itself, so I assumed we'd just presume that port is available when running them. However, people may not expect this to happen if they don't run the tests for NBD (this is a file-specific test after all), so nbd+unix seems like a very good alternative (maybe we should do that even for the "real" NBD tests...?), so I'll (probably) use that in v6. Thanks! Max