Re: [Qemu-devel] [PATCH] scsi-hd: fix property unset case

[Max Reitz <mreitz@redhat.com>]

On 2015-03-04 at 09:12, Kevin Wolf wrote:
> Am 04.03.2015 um 14:58 hat Max Reitz geschrieben:
>> On 2015-03-04 at 07:23, Kevin Wolf wrote:
>>> Am 04.03.2015 um 11:02 hat Ekaterina Tumanova geschrieben:
>>>> commit "BlockConf: Call backend functions to detect geometry and
>>>> blocksizes" causes a segmentation fault on the invalid configuration of
>>>> a scsi device without a drive.
>>>>
>>>> Lets check for conf.blk before calling blkconf_blocksizes. The error
>>>> will be handled later on in scsi_realize anyway.
>>>>
>>>> Reported-by: Max Reitz <mreitz@redhat.com>
>>>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>>>> Signed-off-by: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
>>> Thanks, added the commit ID of the regression to the commit message, and
>>> applied to the block branch.
>> But that commit is not yet upstream, so the ID won't be stable. Are
>> you planning to change it once it's merged?
> Unless someone touches the pull request (which he shouldn't), the commit
> ID is going to stay.

Oh, that's nice, I didn't know that. Thanks for explaining.

Max