From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAAY-0006JM-7M for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:21:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTAAT-0000X4-Jh for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:21:02 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49509 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTAAT-0000W2-Bc for qemu-devel@nongnu.org; Wed, 04 Mar 2015 09:20:57 -0500 Message-ID: <54F714C7.1070104@suse.de> Date: Wed, 04 Mar 2015 15:20:55 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> <1425435224-2630-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1425435224-2630-4-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 3/5] target-i386: Move CPUX86State.cpuid_apic_id to X86CPU.apic_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Gu Zheng , Igor Mammedov , Paolo Bonzini Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > The field doesn't need to be inside CPUState, and it is not specific fo= r You mean CPUX86State or CPUArchState, I guess. :) > the CPUID instruction, so move and rename it. >=20 > Reviewed-by: Paolo Bonzini > Reviewed-by: Andreas F=C3=A4rber > Signed-off-by: Eduardo Habkost Could you please use Class::field syntax for consistency when you apply? Cheers, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)