From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTBMx-00049n-EJ for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTBMt-0007RW-Qy for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:37:55 -0500 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:32980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTBMt-0007R7-L5 for qemu-devel@nongnu.org; Wed, 04 Mar 2015 10:37:51 -0500 Received: by wevl61 with SMTP id l61so10209858wev.0 for ; Wed, 04 Mar 2015 07:37:50 -0800 (PST) Message-ID: <54F726CA.1030602@gmail.com> Date: Wed, 04 Mar 2015 17:37:46 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1423064635-19045-1-git-send-email-marcel@redhat.com> <54EDB81B.9000101@gmail.com> In-Reply-To: <54EDB81B.9000101@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, james.hogan@imgtec.com, mst@redhat.com, jan.kiszka@siemens.com, agraf@suse.de, scottwood@freescale.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net On 02/25/2015 01:55 PM, Marcel Apfelbaum wrote: > On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote: >> Commit e79d5a6 ("machine: remove qemu_machine_opts global list") removed option >> descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. >> >> This results in a Qemu crash if a non string option is queried using qemu opts. >> Fix this by querying machine properties through designated wrappers. >> >> I hope I didn't miss anything. >> Comments are appreciated as always. > Ping Ping ping :) Thanks, Marcel > > Hi, who can take this series? > It solves some command line bugs and people were pretty annoyed about it. > > Thanks, > Marcel > >> >> Thanks, >> Marcel >> >> Marcel Apfelbaum (8): >> machine: query iommu machine property rather than qemu opts >> hw/machine: kernel-irqchip property support for allowed/required >> machine: query kernel-irqchip machine property rather than qemu opts >> kvm: add machine state to kvm_arch_init >> machine: query kvm-shadow-mem machine property rather than qemu opts >> machine: query phandle-start machine property rather than qemu opts >> machine: query dump-guest-core machine property rather than qemu opts >> machine: query mem-merge machine property rather than qemu opts >> >> device_tree.c | 5 ++--- >> exec.c | 6 +++--- >> hw/core/machine.c | 52 +++++++++++++++++++++++++++++++++++++++++++--------- >> hw/pci-host/q35.c | 2 +- >> hw/ppc/e500.c | 16 +++++----------- >> hw/ppc/spapr.c | 16 ++++++---------- >> include/hw/boards.h | 10 +++++++++- >> include/sysemu/kvm.h | 2 +- >> kvm-all.c | 8 ++++---- >> target-arm/kvm.c | 2 +- >> target-i386/kvm.c | 5 ++--- >> target-mips/kvm.c | 2 +- >> target-ppc/kvm.c | 2 +- >> target-s390x/kvm.c | 2 +- >> 14 files changed, 80 insertions(+), 50 deletions(-) >> >