qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <stefan.weil@weilnetz.de>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] advance minimum required GLib version to 2.22
Date: Wed, 04 Mar 2015 22:09:01 +0100	[thread overview]
Message-ID: <54F7746D.2060107@weilnetz.de> (raw)
In-Reply-To: <1425396538-16765-1-git-send-email-imammedo@redhat.com>

Am 03.03.2015 um 16:28 schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>   configure | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index 7ba4bcb..db79e0a 100755
> --- a/configure
> +++ b/configure
> @@ -2744,12 +2744,7 @@ fi
>   ##########################################
>   # glib support probe
>   
> -if test "$mingw32" = yes; then
> -    # g_poll is required in order to integrate with the glib main loop.
> -    glib_req_ver=2.20
> -else
> -    glib_req_ver=2.12
> -fi
> +glib_req_ver=2.22
>   glib_modules=gthread-2.0
>   if test "$modules" = yes; then
>       glib_modules="$glib_modules gmodule-2.0"

A comment in the commit message (or even in file configure) why 2.22 is 
needed would be helpful (this applies also to other requirements).

I typically face the problem that I want to run a build test on a 
platform which does not support the latest package versions (e. g. 
Debian stable or Windows). Then I usually try to lower the requirements 
until the feature which depends on that requirement is enabled. 
Especially for glib the requirements for Linux, Mac and Windows might 
also differ.

Regards
Stefan

      reply	other threads:[~2015-03-04 21:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 15:28 [Qemu-devel] [PATCH] advance minimum required GLib version to 2.22 Igor Mammedov
2015-03-04 21:09 ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F7746D.2060107@weilnetz.de \
    --to=stefan.weil@weilnetz.de \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).