From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTIgc-0008MS-Ba for qemu-devel@nongnu.org; Wed, 04 Mar 2015 18:26:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTIgS-0002eL-OD for qemu-devel@nongnu.org; Wed, 04 Mar 2015 18:26:42 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:38879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTIgS-0002eB-Iq for qemu-devel@nongnu.org; Wed, 04 Mar 2015 18:26:32 -0500 Received: by pdbfl12 with SMTP id fl12so30065487pdb.5 for ; Wed, 04 Mar 2015 15:26:30 -0800 (PST) Message-ID: <54F794A0.2030504@ozlabs.ru> Date: Thu, 05 Mar 2015 10:26:24 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1425432686-29851-1-git-send-email-aik@ozlabs.ru> <54F6FA53.5080106@suse.de> <54F71336.60806@suse.de> In-Reply-To: <54F71336.60806@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add versions to server CPU descriptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Alexander Graf , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 03/05/2015 01:14 AM, Andreas Färber wrote: > Alex, > > Am 04.03.2015 um 13:28 schrieb Alexander Graf: >> On 04.03.15 02:31, Alexey Kardashevskiy wrote: >>> 5b79b1c "target-ppc: Create versionless CPU class per family if KVM" added >>> a dynamic CPU class registration with the name of the CPU family which >>> QEMU is running on. For example, this allowed specifying "-cpu POWER7" >>> on every version of POWER7 machine, not just the one which POWER7 was >>> an alias of. I.e. before 5b79b1c, "-cpu POWER7" would not work on real >>> POWER7 2.1 and would work on POWER7 2.3 only. The same story for POWER8. >>> >>> However that patch broke POWER5+ support as POWER5+ CPU uses the same >>> name as the CPU class so dynamic registering of the POWER5+ class failed. >>> >>> This redefines POWER5+ server CPUs by adding a version to them and adding >>> an alias for TCG case. KVM will use dynamically registered CPUs. >>> >>> While we are here, do the same for 970 CPU. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Thanks, applied to ppc-next. > > As Alexey predicted, I object. > > The 970 part looks good and could be applied immediately if it were a > separate patch. > > But the POWER5+ part I have my doubts about: Was there really a v0.0??? > Others start with v1.0 and I have: > > revision : 2.1 (pvr 003b 0201) > > Also, this is still just bandaid and not a fix to the code that I > pointed out. Does QEMU work for you now, with this patch? How and where (real power5? power7?) do you run QEMU exactly to hit the bug? > But let's keep that discussion over at the other patch. oookay :) -- Alexey