From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTJZ5-00058b-IE for qemu-devel@nongnu.org; Wed, 04 Mar 2015 19:23:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTJZ1-0005pf-Gp for qemu-devel@nongnu.org; Wed, 04 Mar 2015 19:22:59 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57319 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTJZ1-0005oy-AI for qemu-devel@nongnu.org; Wed, 04 Mar 2015 19:22:55 -0500 Message-ID: <54F7A1DC.7020402@suse.de> Date: Thu, 05 Mar 2015 01:22:52 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1425435224-2630-1-git-send-email-ehabkost@redhat.com> <1425435224-2630-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1425435224-2630-6-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 5/5] target-i386: Require APIC ID to be explicitly set before CPU realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Gu Zheng , Igor Mammedov , Paolo Bonzini Am 04.03.2015 um 03:13 schrieb Eduardo Habkost: > On softmuu, instead of setting APIC ID automatically when creating a > X86CPU, require the property to be set before realizing the object > (which is already done by the CPU creation code on PC). >=20 > Keep apic_id =3D 0 by default on *-user so it can simply create a new C= PU > object and realize it without extra steps (so target-i386 will be able > to use cpu_generic_init() eventually). >=20 > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu-qom.h | 2 +- > target-i386/cpu.c | 10 ++++++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Andreas F=E4rber Thanks, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)