From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59756)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YTLWS-00008E-1u
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 21:28:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YTLWQ-0003Nr-OP
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 21:28:23 -0500
Message-ID: <54F7BEC9.1060204@huawei.com>
Date: Thu, 5 Mar 2015 10:26:17 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1425023419-12244-1-git-send-email-arei.gonglei@huawei.com>
	<1425023419-12244-3-git-send-email-arei.gonglei@huawei.com>
	<54F705B0.8040308@msgid.tls.msk.ru>
In-Reply-To: <54F705B0.8040308@msgid.tls.msk.ru>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/9] arm: fix memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, peter.huangpeng@huawei.com, armbru@redhat.com

On 2015/3/4 21:16, Michael Tokarev wrote:
> 27.02.2015 10:50, arei.gonglei@huawei.com wrote:
> []
>> @@ -565,6 +565,7 @@ static void create_flash(const VirtBoardInfo *vbi)
>>              error_report("Could not load ROM image '%s'", bios_name);
>>              exit(1);
>>          }
>> +        g_free(fn);
>>      }
>>  
>>      create_one_flash("virt.flash0", flashbase, flashsize);
>>
> 
> This change introduces a compiler error:
> 
> hw/arm/virt.c: In function ‘create_flash’:
> hw/arm/virt.c:568:16: error: passing argument 1 of ‘g_free’ discards ‘const’ qualifier from pointer target type [-Werror]
>          g_free(fn);
>                 ^
> /usr/include/glib-2.0/glib/gmem.h:69:7: note: expected ‘gpointer’ but argument is of type ‘const char *’
>  void  g_free           (gpointer  mem);
>        ^
> 
> This is because just a few lines above, `fn' variable
> is declared as `const char *', which obviously should
> not be used with any *free() functions.
> 
Yes, and I found another similar problem in
 [PATCH 9/9] microblaze: fix memory leak
which you had pulled, maybe make sense wait a minuter.
Sorry for this.
> The solution is to remove `const' from the variable
> declaration.
> 
Correct.
> And a much more general solution is to actually test
> patches before submitting them.  You obviously did not
> test this series, having 3 errors in 9 patches, ie,
> 1/3 of your patches does not work...
> 
Apologize earnestly for troubling you. :(

I just thought they are so trivial, meanwhile I hadn't arm compiling environment (lack of
libfdt-dev), and assigned "--target-list=x86_64-softmmu" that moment.

Regards,
-Gonglei