From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTVXB-0006KH-Dz for qemu-devel@nongnu.org; Thu, 05 Mar 2015 08:09:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTVX7-0004ho-Dy for qemu-devel@nongnu.org; Thu, 05 Mar 2015 08:09:49 -0500 Message-ID: <54F85596.30802@suse.de> Date: Thu, 05 Mar 2015 14:09:42 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1425556583-13895-1-git-send-email-nikunj@linux.vnet.ibm.com> <1425556583-13895-3-git-send-email-nikunj@linux.vnet.ibm.com> In-Reply-To: <1425556583-13895-3-git-send-email-nikunj@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 2/2] spapr: override default ram size to 1GB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania , qemu-devel@nongnu.org Cc: thuth@linux.vnet.ibm.com, aik@ozlabs.ru, armbru@redhat.com, qemu-ppc@nongnu.org, marcel.apfelbaum@gmail.com, imammedo@redhat.com On 05.03.15 12:56, Nikunj A Dadhania wrote: > Signed-off-by: Nikunj A Dadhania > Reviewed-by: Igor Mammedov > --- > hw/ppc/spapr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 23cde20..c71ee4b 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -96,6 +96,7 @@ typedef struct sPAPRMachineState sPAPRMachineState; > #define SPAPR_MACHINE(obj) \ > OBJECT_CHECK(sPAPRMachineState, (obj), TYPE_SPAPR_MACHINE) > > +#define SPAPR_DEFAULT_RAM_SIZE (1UL << 30) UL is almost always wrong on QEMU land. Please use ULL. Also I find 1 << 30 pretty hard to read. Can't we just define simple KB/MB/GB/TB helpers somewhere in a header file and just fold this is below as .. > /** > * sPAPRMachineState: > */ > @@ -1738,6 +1739,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data) > mc->max_cpus = MAX_CPUS; > mc->no_parallel = 1; > mc->default_boot_order = NULL; > + mc->default_ram_size = SPAPR_DEFAULT_RAM_SIZE; mc->default_ram_size = 1 * GB; Alex > mc->kvm_type = spapr_kvm_type; > mc->has_dynamic_sysbus = true; > >