From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YThRT-00030l-Su for qemu-devel@nongnu.org; Thu, 05 Mar 2015 20:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YThRQ-0000bC-L4 for qemu-devel@nongnu.org; Thu, 05 Mar 2015 20:52:43 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:4320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YThRP-0000a3-P0 for qemu-devel@nongnu.org; Thu, 05 Mar 2015 20:52:40 -0500 Message-ID: <54F90856.3030809@huawei.com> Date: Fri, 6 Mar 2015 09:52:22 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1425562294-1616-1-git-send-email-dgilbert@redhat.com> <54F9077B.3020803@huawei.com> In-Reply-To: <54F9077B.3020803@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/1] Rolling stats on colo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, luis@cs.umu.se On 2015/3/6 9:48, zhanghailiang wrote: > On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote: >> From: "Dr. David Alan Gilbert" > > Hi Dave, > >> >> Hi, >> I'm getting COLO running on a couple of our machines here >> and wanted to see what was actually going on, so I merged >> in my recent rolling-stats code: >> >> http://lists.gnu.org/archive/html/qemu-devel/2015-03/msg00648.html >> >> with the following patch, and now I get on the primary side, >> info migrate shows me: >> >> capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off colo: on >> Migration status: colo >> total time: 0 milliseconds >> colo checkpoint (ms): Min/Max: 0, 10000 Mean: -1.1415868e-13 (Weighted: 4.3136025e-158) Count: 4020 Values: 0@1425561742237, 0@1425561742300, 0@1425561742363, 0@1425561742426, 0@1425561742489, 0@1425561742555, 0@1425561742618, 0@1425561742681, 0@1425561742743, 0@1425561742824 >> colo paused time (ms): Min/Max: 55, 2789 Mean: 63.9 (Weighted: 76.243584) Count: 4019 Values: 62@1425561742237, 62@1425561742300, 62@1425561742363, 62@1425561742426, 61@1425561742489, 65@1425561742555, 62@1425561742618, 62@1425561742681, 61@1425561742743, 80@1425561742824 >> colo checkpoint size: Min/Max: 18351, 2.1731606e+08 Mean: 150096.4 (Weighted: 127195.56) Count: 4020 Values: 211246@1425561742238, 186622@1425561742301, 227662@1425561742364, 219454@1425561742428, 268702@1425561742490, 96334@1425561742556, 47086@1425561742619, 42982@1425561742682, 55294@1425561742744, 145582@1425561742825 >> >> which suggests I've got a problem with the packet comparison; but that's >> a separate issue I'll look at. >> > > There is an obvious mistake we have made in proxy, the macro 'IPS_UNTRACKED_BIT' in colo-patch-for-kernel.patch should be 14, s/IPS_UNTRACKED_BIT/IPS_COLO_TEMPLATE_BIT > so please fix it before do the follow test. Sorry for this low-grade mistake, we should do full test before issue it. ;) > > To be honest, the proxy part in github is not integrated, we have cut it just for easy review and understand, so there may be some mistakes. > > Thanks, > zhanghailiang > > >> Dave >> >> Dr. David Alan Gilbert (1): >> COLO: Add primary side rolling statistics >> >> hmp.c | 12 ++++++++++++ >> include/migration/migration.h | 3 +++ >> migration/colo.c | 15 +++++++++++++++ >> migration/migration.c | 30 ++++++++++++++++++++++++++++++ >> qapi-schema.json | 11 ++++++++++- >> 5 files changed, 70 insertions(+), 1 deletion(-) >> >