From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTilt-0007X3-Tt for qemu-devel@nongnu.org; Thu, 05 Mar 2015 22:17:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTilp-00072m-Ay for qemu-devel@nongnu.org; Thu, 05 Mar 2015 22:17:53 -0500 Received: from [59.151.112.132] (port=7547 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTilo-00071p-Vq for qemu-devel@nongnu.org; Thu, 05 Mar 2015 22:17:49 -0500 Message-ID: <54F91AC0.1080304@cn.fujitsu.com> Date: Fri, 6 Mar 2015 11:10:56 +0800 From: Chen Fan MIME-Version: 1.0 References: <51c47e4ac4982ecb323ac0ef2bf65bba48646cfb.1423821709.git.zhugh.fnst@cn.fujitsu.com> <20150305181710.GH13041@thinpad.lan.raisama.net> In-Reply-To: <20150305181710.GH13041@thinpad.lan.raisama.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 01/10] cpu/apic: drop icc bus/bridge/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Zhu Guihua Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, imammedo@redhat.com, guz.fnst@cn.fujitsu.com, anshul.makkar@profitbricks.com, afaerber@suse.de On 03/06/2015 02:17 AM, Eduardo Habkost wrote: > On Fri, Feb 13, 2015 at 06:25:24PM +0800, Zhu Guihua wrote: >> From: Chen Fan >> >> ICC bus was invented only to provide hotplug capability to >> CPU and APIC because at the time being hotplug was available only for >> BUS attached devices. >> >> Now this patch is to drop ICC bus impl, and switch to bus-less >> CPU+APIC hotplug, handling them in the same manner as pc-dimm. >> >> Signed-off-by: Chen Fan >> Signed-off-by: Zhu Guihua >> --- >> hw/i386/kvm/apic.c | 10 ++++++++-- >> hw/i386/pc.c | 21 +++++---------------- >> hw/i386/pc_piix.c | 9 +-------- >> hw/i386/pc_q35.c | 9 +-------- >> hw/intc/apic.c | 16 +++++++++++----- >> hw/intc/apic_common.c | 14 +++++++++----- >> include/hw/i386/apic_internal.h | 6 ++---- >> include/hw/i386/pc.h | 3 ++- >> target-i386/cpu.c | 19 +++---------------- >> target-i386/cpu.h | 3 +-- >> 10 files changed, 43 insertions(+), 67 deletions(-) > What about hw/i386/xen/xen_apic.c:xen_apic_realize()? > > $ make > CC x86_64-softmmu/hw/i386/xen/xen_apic.o > /home/ehabkost/rh/proj/virt/qemu/hw/i386/xen/xen_apic.c: In function = =E2=80=98xen_apic_realize=E2=80=99: > /home/ehabkost/rh/proj/virt/qemu/hw/i386/xen/xen_apic.c:44:29: error: = =E2=80=98APICCommonState=E2=80=99 has no member named =E2=80=98io_memory=E2= =80=99 > memory_region_init_io(&s->io_memory, OBJECT(s), &xen_apic_io_ops,= s, > ^ > /home/ehabkost/rh/proj/virt/qemu/rules.mak:57: recipe for target 'hw/i= 386/xen/xen_apic.o' failed > make[1]: *** [hw/i386/xen/xen_apic.o] Error 1 > Makefile:169: recipe for target 'subdir-x86_64-softmmu' failed > make: *** [subdir-x86_64-softmmu] Error 2 Oh, I'm sorry for that, because no xen platform environment. we forgot=20 xen ;). so I want to fix it and rebase our patches under your x86 tree. Thanks, Chen >