From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YTntK-0004rL-2o
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 03:45:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YTntE-0006Ze-0k
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 03:45:54 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:12740)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1YTntD-0006Qx-Dn
	for qemu-devel@nongnu.org; Fri, 06 Mar 2015 03:45:47 -0500
Message-ID: <54F9691B.2000608@huawei.com>
Date: Fri, 6 Mar 2015 16:45:15 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1425478176-12044-1-git-send-email-zhang.zhanghailiang@huawei.com>	<1425478176-12044-4-git-send-email-zhang.zhanghailiang@huawei.com>
	<87oao7pa3d.fsf@blackfin.pond.sub.org>
In-Reply-To: <87oao7pa3d.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of
 MigrationInfo to use an enum type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: hangaohuai@huawei.com, quintela@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, lcapitulino@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com

On 2015/3/6 2:34, Markus Armbruster wrote:
> zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
>
>> The original 'status' is an open-coded 'str' type, convert it to use an
>> enum type.
>> This conversion is backwards compatible, better documented and
>> more convenient for future extensibility.
>>
>> We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION_STATUS_FAILED'.
>> In addition, Fix a typo for qapi-schema.json: comppleted -> completed
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> [...]
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index e16f8eb..3b5904b 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>>   ##
>>   # @MigrationInfo
>>   #
>>   # Information about current migration process.
>>   #
>> -# @status: #optional string describing the current migration status.
>> -#          As of 0.14.0 this can be 'setup', 'active', 'completed', 'failed' or
>> -#          'cancelled'. If this field is not returned, no migration process
>> +# @status: #optional @MigState describing the current migration status.
>> +#          If this field is not returned, no migration process
>>   #          has been initiated
>>   #
>>   # @ram: #optional @MigrationStats containing detailed migration
>>   #       status, only returned if status is 'active' or
>> -#       'completed'. 'comppleted' (since 1.2)
>> +#       'completed'. 'completed' (since 1.2)
>
> Shouldn't this just be
>
> +#       'completed' (since 1.2)
>

Er, Yes, in this way, it is more clean, thanks, will fix in v4 ~

>
>>   #
>>   # @disk: #optional @MigrationStats containing detailed disk migration
>>   #        status, only returned if status is 'active' and it is a block
>> @@ -453,7 +477,7 @@
>>   # Since: 0.14.0
>>   ##
>>   { 'type': 'MigrationInfo',
>> -  'data': {'*status': 'str', '*ram': 'MigrationStats',
>> +  'data': {'*status': 'MigrationStatus', '*ram': 'MigrationStats',
>>              '*disk': 'MigrationStats',
>>              '*xbzrle-cache': 'XBZRLECacheStats',
>>              '*total-time': 'int',
>
> .
>