From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTurU-0007dl-CG for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:12:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTurJ-0007iW-QI for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:12:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTurJ-0007iF-Hm for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:12:17 -0500 Message-ID: <54F9D17C.2010307@redhat.com> Date: Fri, 06 Mar 2015 09:10:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423711034-5340-1-git-send-email-zhang.zhanghailiang@huawei.com> <1423711034-5340-15-git-send-email-zhang.zhanghailiang@huawei.com> <54E2818C.4000800@redhat.com> <54ED7412.9000302@huawei.com> In-Reply-To: <54ED7412.9000302@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QaDVRdWb9sQgW04IdLIp3Isc916WjiK2D" Subject: Re: [Qemu-devel] [PATCH RFC v3 14/27] COLO failover: Introduce a new command to trigger a failover List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, Lai Jiangshan , Li Zhijian , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QaDVRdWb9sQgW04IdLIp3Isc916WjiK2D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/25/2015 12:04 AM, zhanghailiang wrote: >>> +++ b/qmp-commands.hx >>> @@ -753,6 +753,25 @@ Example: >>> EQMP >>> >>> { >>> + .name =3D "colo_lost_heartbeat", >> >> ...but documented incorrectly (this should use '-' to match the comman= d >> name in the .json file, not '_') >> >=20 > Er, yes, you are right, here it should be 'colo-lost-heartbeat' in > qmp-commands.hx, > but 'colo_lost_heartbeat' in hmp-commands.hx, it is a little confused > for me, > why it should be like this? Historical madness. HMP has traditionally used '_' (and relied on tab-completion to allow users to skip having to use the shift key), while QMP has traditionally used '-' (in all but the oldest interfaces). >=20 > i will fix it. >=20 >>> + .args_type =3D "", >>> + .mhandler.cmd_new =3D qmp_marshal_input_colo_lost_heartbeat,= >>> + }, >>> + >>> +SQMP >>> +colo_lost_heartbeat >>> +-------------------- >>> + >>> +Tell COLO that heartbeat is lost, a failover or takeover is needed. >>> + >>> +Example: >>> + >>> +-> { "execute": "colo_lost_heartbeat" } >>> +<- { "return": {} } >> >> This example won't work unless you fix the spelling. >> >=20 > Should here also be changed to 'colo-lost-heartbeat' ? Yes. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QaDVRdWb9sQgW04IdLIp3Isc916WjiK2D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU+dF8AAoJEKeha0olJ0NqofAH+gJn6rufwIvXEb3PW6U1jrui UJUGWzVSKEUlUV9+s6kw3SZ6PBOUB9yCVZ9BBe1fyyOdlhc2zAg26diYJGTe/QYR G36xtY71kW1fr4gkA1QBR1xh1E9uo80nhGe7n0ZzIqIkQXo9G7dE5+KWsan9AY5O bCTP5mvGLZJMJ5qDn1vMcDlXjwsJ5bhRpGtKskHA/RWDOqZyTVzgfVgdHR4GmeeE oztgZE82kGbr2ahcfUr0ZkZ9JLh7i/285JUgsW5hvXuSw8lTQJMlAMn8X225dxEh Wtig23cn6JlO+LK3Qe4KGBlt1YhVGW9euJBcnoEfswKXdS7bgppfs6lyJx1K22w= =kxVv -----END PGP SIGNATURE----- --QaDVRdWb9sQgW04IdLIp3Isc916WjiK2D--