From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: quintela@redhat.com, armbru@redhat.com,
peter.huangpeng@huawei.com, lcapitulino@redhat.com,
amit.shah@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type
Date: Fri, 06 Mar 2015 09:17:34 -0700 [thread overview]
Message-ID: <54F9D31E.505@redhat.com> (raw)
In-Reply-To: <1425478176-12044-4-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On 03/04/2015 07:09 AM, zhanghailiang wrote:
> The original 'status' is an open-coded 'str' type, convert it to use an
> enum type.
> This conversion is backwards compatible, better documented and
> more convenient for future extensibility.
>
> We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION_STATUS_FAILED'.
I argue that this change should be done in 1/4.
> In addition, Fix a typo for qapi-schema.json: comppleted -> completed
but this one can stay here.
>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> hmp.c | 7 ++++---
> migration/migration.c | 34 ++++++++++++----------------------
> qapi-schema.json | 34 +++++++++++++++++++++++++++++-----
> 3 files changed, 45 insertions(+), 30 deletions(-)
>
Otherwise, modulo Markus' review, it's looking better.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-06 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 14:09 [Qemu-devel] [PATCH v3 0/4] Convert 'status' of MigrationInfo from open-coded 'str' to enum type zhanghailiang
2015-03-04 14:09 ` [Qemu-devel] [PATCH v3 1/4] migration: Rename abbreviated macro MIG_STATE_* to MIGRATION_STATUS_* zhanghailiang
2015-03-06 16:14 ` Eric Blake
2015-03-09 1:26 ` zhanghailiang
2015-03-04 14:09 ` [Qemu-devel] [PATCH v3 2/4] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus' zhanghailiang
2015-03-06 16:14 ` Eric Blake
2015-03-04 14:09 ` [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type zhanghailiang
2015-03-05 18:34 ` Markus Armbruster
2015-03-06 8:45 ` zhanghailiang
2015-03-06 16:17 ` Eric Blake [this message]
2015-03-04 14:09 ` [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user zhanghailiang
2015-03-06 16:24 ` Eric Blake
2015-03-09 1:27 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9D31E.505@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).