From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTv3b-0007nP-VH for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:25:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTv3Z-0005nJ-6p for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:24:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTv3Y-0005mn-VO for qemu-devel@nongnu.org; Fri, 06 Mar 2015 11:24:57 -0500 Message-ID: <54F9D4C0.8010705@redhat.com> Date: Fri, 06 Mar 2015 09:24:32 -0700 From: Eric Blake MIME-Version: 1.0 References: <1425478176-12044-1-git-send-email-zhang.zhanghailiang@huawei.com> <1425478176-12044-5-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1425478176-12044-5-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BLHD2BPVcVqaCn32RQRRAIQ98arbcQuT2" Subject: Re: [Qemu-devel] [PATCH v3 4/4] migration: Expose 'cancelling' status to user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: quintela@redhat.com, libvir-list@redhat.com, armbru@redhat.com, peter.huangpeng@huawei.com, lcapitulino@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BLHD2BPVcVqaCn32RQRRAIQ98arbcQuT2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/2015 07:09 AM, zhanghailiang wrote: > 'cancelling' status is introduced by commit 51cf4c1a, which is mainly a= void s/is introduced/was introduced/ s/which is mainly avoid/mainly to avoid a/ > possible starting a new migration process while the previous one still = exist. s/starting a new/start of a new/ s/exist/exists/ > But we don't expose this status to user, instead by return a 'active' s= tate. s/don't/didn't/ s/by return a/we returned the/ >=20 > Here, we expose it to the user (such as libvirt), 'cancelling' status o= nly > occurs for a short window before the migration aborts, so for users, > if they cancell a migration process, it will observe 'cancelling' statu= s s/cancell/cancel/ > occasionally. Add: Testing revealed that with older libvirt (anything 1.2.13 or less) will print an odd error message if the state is seen, but that the migration is still properly cancelled. Newer libvirt will be patched to recognize the new state without the odd error message. >=20 > Signed-off-by: zhanghailiang > Cc: libvir-list@redhat.com > --- > migration/migration.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) With the grammar in the commit message fixed, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BLHD2BPVcVqaCn32RQRRAIQ98arbcQuT2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU+dTAAAoJEKeha0olJ0NqQKoH/jlzmK2P/+MgpE9VEACyxjzA UROU7J1aluzu+0zLUI16nO5ISbjcAzjWsp3LhNs0wIA73Hit/b73we1l7SWvEG/n Ns0aK+uNUjE4axVBj0vmkgWN+LSe4hLIXiDoc3FWGqOckQCWO6TdRa6R5jUz4Yi0 I1kwMb+9AFGzZJNgyXJ39st2KCDdieWqps1TCI1OA0LqJ5ePfcC4WqpKSsXBqXH7 xj0bYl7Q6SiQJ97FoRd4YKrbINSmj9ACfpP4y2FlUcFvE383gCuxHyHLTHJBHCqI D21oDEcLpZeC/Rk5xeTz4M4BuTBm/RtOHE4MWO0qzMQnyUzPX//EqdRZsUwOKsQ= =hpRr -----END PGP SIGNATURE----- --BLHD2BPVcVqaCn32RQRRAIQ98arbcQuT2--