From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns"
Date: Fri, 06 Mar 2015 10:14:22 -0700 [thread overview]
Message-ID: <54F9E06E.5030200@redhat.com> (raw)
In-Reply-To: <1425519178-17863-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On 03/04/2015 06:32 PM, Fam Zheng wrote:
> Aio context switch should just work because the requests will be
> drained, so the scheduled timer(s) on the old context will be freed.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> ---
> v2: Check for negative value; add sleep in null-co://. [Kevin]
> ---
> block/null.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 50 insertions(+), 5 deletions(-)
Is it possible to pass this new parameter via QMP? If so, shouldn't the
.json file also document it? And if so, should it be named with '-'
instead of '_' for use from QMP?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-06 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 1:32 [Qemu-devel] [PATCH v2] block/null: Latency simulation by adding new option "latency_ns" Fam Zheng
2015-03-06 17:14 ` Eric Blake [this message]
2015-03-11 5:16 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9E06E.5030200@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).