From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTwvb-0000EX-SU for qemu-devel@nongnu.org; Fri, 06 Mar 2015 13:24:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTwva-0002pj-Rd for qemu-devel@nongnu.org; Fri, 06 Mar 2015 13:24:51 -0500 Message-ID: <54F9F0D1.3070101@redhat.com> Date: Fri, 06 Mar 2015 20:24:17 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1425567322-8337-1-git-send-email-marcel@redhat.com> <1425567322-8337-5-git-send-email-marcel@redhat.com> <20150306114052.086620b0@nial.brq.redhat.com> In-Reply-To: <20150306114052.086620b0@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 for-2.3 04/24] acpi: add aml_index() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: quintela@redhat.com, seabios@seabios.org, agraf@suse.de, qemu-devel@nongnu.org, alex.williamson@redhat.com, kevin@koconnor.net, mst@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, hare@suse.de On 03/06/2015 12:40 PM, Igor Mammedov wrote: > On Thu, 5 Mar 2015 16:55:02 +0200 > Marcel Apfelbaum wrote: > >> Add encoding for ACPI DefIndex Opcode. >> >> Signed-off-by: Marcel Apfelbaum >> --- >> hw/acpi/aml-build.c | 10 ++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 11 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 611c949..0b3fcda 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -477,6 +477,16 @@ Aml *aml_add(Aml *arg1, Aml *arg2) >> return var; >> } >> >> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIndex */ >> +Aml *aml_index(Aml *arg1, Aml *idx) >> +{ >> + Aml *var = aml_opcode(0x88 /* IndexOp */); > could you add assert to check that Arg1 is BuffPkgStrObj? Sure, thanks! Marcel > >> + aml_append(var, arg1); >> + aml_append(var, idx); >> + build_append_int(var->buf, 0x00 /* NullNameOp */); >> + return var; >> +} >> + >> /* ACPI 1.0b: 16.2.5.3 Type 1 Opcodes Encoding: DefNotify */ >> Aml *aml_notify(Aml *arg1, Aml *arg2) >> { >> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h >> index edc0520..b860732 100644 >> --- a/include/hw/acpi/aml-build.h >> +++ b/include/hw/acpi/aml-build.h >> @@ -140,6 +140,7 @@ Aml *aml_and(Aml *arg1, Aml *arg2); >> Aml *aml_or(Aml *arg1, Aml *arg2); >> Aml *aml_lless(Aml *arg1, Aml *arg2); >> Aml *aml_add(Aml *arg1, Aml *arg2); >> +Aml *aml_index(Aml *arg1, Aml *idx); >> Aml *aml_notify(Aml *arg1, Aml *arg2); >> Aml *aml_call1(const char *method, Aml *arg1); >> Aml *aml_call2(const char *method, Aml *arg1, Aml *arg2); >